fix(unity-react-core): sidebar menu should auto-expand if it contains… #1568
+69
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an active page item
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1568/index.html |
… an active page item
mlsamuelson
requested changes
Nov 18, 2025
Member
mlsamuelson
left a comment
mlsamuelson
left a comment
There was a problem hiding this comment.
In the PR site the highlight is on the top level parent instead of the active child link. Doesn't match what I see and expect from the screenshots on https://asudev.jira.com/browse/UDS-1598
Also I don't recall what was decided about the JS that may be needed for the Bootstrap theme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sidebar menu should auto-expand if it contains an active page item
Checklist
Important Reminders
Links